[4주차] 한하람/[feat] 추가 api 구현#162
Merged
Hanharam merged 12 commits intoLeets-Official:한하람/mainfrom May 3, 2026
Hidden character warning
The head ref may contain hidden characters: "\ud55c\ud558\ub78c/4\uc8fc\ucc28"
Merged
Conversation
gusanans218
approved these changes
Apr 30, 2026
gusanans218
left a comment
gusanans218
left a comment
There was a problem hiding this comment.
신고 기능을 포트/어댑터 구조로 분리해서 구현한 점이 좋았습니다
Controller → UseCase → Service → Port → PersistenceAdapter 흐름이 명확해서 각 계층의 책임이 잘 드러나는 코드라고 느꼈습니다!!
N-yujeong
approved these changes
Apr 30, 2026
N-yujeong
left a comment
N-yujeong
left a comment
There was a problem hiding this comment.
👍 ResourceType과 PermissionType으로 권한 체계를 깔끔하게 설계하신 부분이 좋습니다!
LoadCommentPort의 TODO에서 언급하신 대로, existsById 기반 검증보다는 실제 Comment 도메인을 조회하는 방식으로 변경하면 더 강력한 설계가 될 것 같습니다.
jihoonkim501
approved these changes
Apr 30, 2026
jihoonkim501
left a comment
jihoonkim501
left a comment
There was a problem hiding this comment.
제가 헥사고날 아키텍쳐를 잘 몰라서 어렵군요.. 그래도 코드가 간결하고 일관성이 있어서 그나마 잘 읽히는 것 같습니다! 수고하셨습니다 하람님~!
Comment on lines
+89
to
+101
| // 신고자 아이디 검증 | ||
| private static void validateReporterId(Long reporterId) { | ||
| if (reporterId == null || reporterId <= 0) { | ||
| throw new ReportDomainException(ReportErrorCode.INVALID_REPORTER_ID); | ||
| } | ||
| } | ||
| // 타겟 유형 검증 | ||
| private static void validateTargetType(ReportTargetType targetType) { | ||
| if (targetType == null) { | ||
| throw new ReportDomainException(ReportErrorCode.INVALID_TARGET_TYPE); | ||
| } | ||
| } | ||
| // 타겟 아이디 검증 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
2. 핵심 변경 사항
3. 실행 및 검증 결과
한번 더 신고:
게시글이 존재하지 않음:
한번 더 신고:
댓글이 존재하지 않음:
250자 초과:
검토중 한번 더 실행:
잘못된 report Id:
4. 완료 사항
5. 추가 사항
제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer 참고